CI bumps #110
Open
CI bumps #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump 2.4.3 -> 2.4.4. Bump 2.5.4 -> 2.5.5. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Version 1.60 supports Go 1.23. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
As of today, Go 1.23 is released and thus Go 1.21.x is no longer supported. Test against the two supported Go branches: 1.22.x and 1.23.x. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
ci-bumps
branch
2 times, most recently
from
f10e302 to
f8911f6
Compare
Since actions/setup-go@v4 it caches some go directories to speed up building, testing etc. Alas, we link our code against different libseccomp versions, and such caching my screw up builds. To fix this, add libseccomp version information to cache keys. The only way to do so in actions/setup-go is a file, so supply it with libseccomp.pc which contains libseccomp version and is otherwise rarely updated. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
OK, I guess what happens here is actions/setup-go@v5 caches some Go files and then they are restored in an environment with different version of libseccomp installed, resulting in sporadic failures. Let's try to add libseccomp version to cache key. |
It works, and I am seeing from the logs that cache is being reused. That said, it will be an improvement to also cache compiled libseccomp, but that's a task for another PR. |
drakenclimber
approved these changes
Aug 15, 2024
The only change needed is a flag for pip install, as in Ubuntu-24.04 it is patched to error out saying to use apt. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This is to avoid breaking CI when a new version comes out. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
Looks good to me. Thanks, @kolyshkin
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for details. This includes bump to Go 1.23.